Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Support Keras API #909

Closed
futurely opened this issue Oct 7, 2019 · 4 comments
Closed

[RFC] Support Keras API #909

futurely opened this issue Oct 7, 2019 · 4 comments

Comments

@futurely
Copy link

futurely commented Oct 7, 2019

🚀 Feature

Use the Keras API alongside with the PyTorch and MXNet API.

There are some examples of implementing graph neural networks with Keras.

https://github.com/search?o=desc&q=keras+graph+network&s=stars&type=Repositories

Motivation

Keras is very popular among deep learning researchers and practitioners.

TensorFlow 2.0 uses Keras as the high level API.

Pitch

More potential users who are familiar with Keras.

@Chillee
Copy link

Chillee commented Oct 9, 2019

However, Keras does not support PyTorch nor MxNet. Keras has also dropped support for its other backends (CNTK/Theano).

If the developers want to support other backends, they can. But supporting Keras out of some misplaced notion that you want to unify the API for different backends is a strange idea.

@futurely
Copy link
Author

It is difficult to support tensorflow and therefore tf.keras due to dependency on dlpack.

@yzh119
Copy link
Member

yzh119 commented Oct 10, 2019

We are working on dlpack support for tensorflow, it would not be difficult to support tf once it is done.

@futurely futurely changed the title Use the Keras API to unify the different backends Support Keras API Oct 10, 2019
@futurely futurely changed the title Support Keras API [RFC] Support Keras API Oct 14, 2019
@BarclayII
Copy link
Collaborator

BarclayII commented Oct 15, 2019

I agree with @Chillee : supporting Tensorflow makes total sense, but the idea of "unifying PyTorch, MXNet and Tensorflow under Keras" is awkward.

EDIT: sorry that I didn't see the edited post. I would say that this is identical to supporting Tensorflow so I'll mark this as a duplicate of #422 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants