Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Accelerate batching #2363

Merged
merged 4 commits into from
Nov 24, 2020
Merged

[Performance] Accelerate batching #2363

merged 4 commits into from
Nov 24, 2020

Conversation

BarclayII
Copy link
Collaborator

Batching is slow in some of the Benchmarking GNN experiments. This PR fixes that.

Copy link
Member

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"""Internal function to batch feature dictionaries.

Parameters
----------
feat_dicts : list[dict[str, Tensor]]
Feature dictionary list.
frames : list[dict[str, Tensor]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change the type signature.

@yzh119 yzh119 merged commit 00edb94 into dmlc:master Nov 24, 2020
wegamekinglc added a commit to wegamekinglc/dgl that referenced this pull request Nov 25, 2020
[Performance] Accelerate batching (dmlc#2363)
BarclayII added a commit to BarclayII/dgl that referenced this pull request Nov 27, 2020
* speed up batching

* more fix

* lint

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants