Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] check whether etype sorted when sampling #4198

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

Rhett-Ying
Copy link
Collaborator

Description

follow-up fix for #4150

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@Rhett-Ying Rhett-Ying added the Release Candidate Candidate PRs for the upcoming release label Jul 1, 2022
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 1, 2022

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 1, 2022

Commit ID: 8f4ff84b60dc4e810f319d44a3fb5755b1e2f547

Build ID: 1

Status: ❌ CI test failed in Stage [GPU Build].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 1, 2022

Commit ID: cce1e98

Build ID: 2

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit dcf1699 into dmlc:master Jul 1, 2022
@Rhett-Ying Rhett-Ying deleted the checkETypeSorted branch July 1, 2022 07:52
@frozenbugs frozenbugs removed the Release Candidate Candidate PRs for the upcoming release label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants