[Feature] Create shared memory graph store. #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manually aggregate neighbors' embeddings with pull.
This reverts commit 86fe2c7.
|
@BarclayII do you have further comments? |
BarclayII
approved these changes
Apr 5, 2019
jermainewang
requested changes
Apr 6, 2019
| shared_mem_name, | ||
| num_nodes, num_edges, | ||
| self._multigraph, | ||
| edge_dir) |
There was a problem hiding this comment.
The from_xxx list is growing too long. We should consider putting them in a dedicate file (e.g. convert.py) in the future.
zheng-da
force-pushed
the
shared_mem_store
branch
2 times, most recently
from
2b217b9
to
23c0cf9
Compare
added 3 commits
April 7, 2019 21:10
This reverts commit 2b217b9.
zheng-da
force-pushed
the
shared_mem_store
branch
from
6412c5e
to
f176bd9
Compare
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to create a shared memory graph store for efficient multiprocessing training. In this way, all trainer processes can access the global graph data efficiently through shared memory. Trainer processes can link to the graph store and create node embeddings and run graph computation in the graph store directly.
Potentially, there is race condition when we update the node/edge embeddings in the graph store. We'll test if this can cause troubles later (e.g., how does it affact the training in GCN with control variate).
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes