Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpu docker tcmalloc #5969

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Conversation

daniil-sizov
Copy link
Contributor

@daniil-sizov daniil-sizov commented Jul 7, 2023

Description

tcmalloc significantly improves performance for large datasets on CPU

Graphsage standalone, ogbn-products (s/epoch):
Intel(R) Xeon(R) Gold 6152 CPU @ 2.10GHz

no tcmalloc tcmalloc
64.8298 54.7999

Graphsage distributed, ogbn-papers100M (s/epoch):
r6i.4xlarge, OMP_NUM_THREADS=6

no tcmalloc tcmalloc
59.9632 44.5427

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 7, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 7, 2023

Commit ID: 022b843

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 7, 2023

Commit ID: 73b42f5

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@daniil-sizov daniil-sizov marked this pull request as ready for review July 10, 2023 10:07
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 10, 2023

Commit ID: d7f81ba99b0970f753fe0a2220a1b28a2dee909c

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 21, 2023

Commit ID: 5b0b99bbdbf14a6e7aef3dfe6d6c42e72fbdbd1d

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 24, 2023

Commit ID: 469d420

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

frozenbugs commented Jul 25, 2023

@Rhett-Ying is out for this week, if not an emergent PR, let's way for Rhett coming back next Monday, @ me again if we need to get it merged sooner.

@Rhett-Ying Rhett-Ying merged commit 9c36f24 into dmlc:master Aug 11, 2023
2 checks passed
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants