Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix cusparseCreateCsr format for cuda12 #6121

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

chang-l
Copy link
Collaborator

@chang-l chang-l commented Aug 9, 2023

Description

According to the doc (cuda 12.2), it states csrRowOffsets must be not NULL for the function cusparseCreateCsr. This PR sets the csrRowOffsets to a proper value for compatible with cuda 12.2 release.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

The fifth argument of cusparseCreateCsr is set to dC_csrOffsets_data.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 9, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 9, 2023

Commit ID: 6a16faa78b0ca82313e82137e4794d439b6bd865

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 9, 2023

Commit ID: eabf5a74f4ae449f5d64948ba073ca8a88251ec3

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs frozenbugs self-requested a review August 10, 2023 00:42
@chang-l chang-l merged commit 88964a8 into dmlc:master Aug 10, 2023
2 checks passed
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants