Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sparse] Add sparse matrix slicing operator implementation #6208

Merged
merged 31 commits into from
Sep 5, 2023
Merged

[Sparse] Add sparse matrix slicing operator implementation #6208

merged 31 commits into from
Sep 5, 2023

Conversation

xiangyuzhi
Copy link
Collaborator

@xiangyuzhi xiangyuzhi commented Aug 25, 2023 •
edited

Description

Sparse slice operator implementation, include index_select and range_select.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 25, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@xiangyuzhi xiangyuzhi changed the title [Sparse] Add one row slice implementation [Sparse] Add one sparse row slice implementation Aug 25, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 25, 2023

Commit ID: 47e1d45e24b9c5d1da5c27ac870dd8b020dd27e2

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

czkkkkkk
czkkkkkk reviewed Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@czkkkkkk czkkkkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pls implement other interfaces in the same fasion.

dgl_sparse/src/python_binding.cc Outdated Show resolved Hide resolved
dgl_sparse/src/sparse_matrix.cc Outdated Show resolved Hide resolved
@czkkkkkk czkkkkkk changed the title [Sparse] Add one sparse row slice implementation [Draft][Sparse] Add one sparse row slice implementation Aug 25, 2023
@xiangyuzhi xiangyuzhi force-pushed the slicing-c branch 2 times, most recently from 3e54113 to 3e490c8 Compare August 29, 2023 01:39
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 29, 2023

Commit ID: 61787ad84688afc654d79fe98775a52cf7d217db

Build ID: 2

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@xiangyuzhi xiangyuzhi mentioned this pull request Aug 29, 2023
Merged
8 tasks
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 29, 2023

Commit ID: a4507e35b761f375eb9d67295fd2609620e08826

Build ID: 3

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@xiangyuzhi xiangyuzhi changed the title [Draft][Sparse] Add one sparse row slice implementation [Sparse] Add one sparse row slice implementation Aug 29, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 29, 2023

Commit ID: acd3ab3446924c1c8629039a972a6e5659e6a7fb

Build ID: 4

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@czkkkkkk czkkkkkk changed the title [Sparse] Add one sparse row slice implementation [Sparse] Add sparse matrix slicing operator implementation Aug 29, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 29, 2023

Commit ID: 9c91c193fe8d85ebf1dbdc22ad44b0afbbe057e7

Build ID: 5

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 30, 2023

Commit ID: 72a338d8f2f18829cb600db5e7b3aac6937848ff

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 30, 2023

Commit ID: 85f929c459ec4c6c7751d01798c25fbc5181be5e

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 4, 2023

Commit ID: 25a487798c193e69567002dbac98ea429a43dd91

Build ID: 12

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 4, 2023

Commit ID: ec8b00f356bef653e41b5a4c7af664ac7bc1cfd4

Build ID: 13

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 4, 2023

Commit ID: eedfcd58fdf4cdde7ff4f2fa5d43a75ef27e34c7

Build ID: 14

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

czkkkkkk
czkkkkkk approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@czkkkkkk czkkkkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments. @frozenbugs, please take a look at this PR.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 5, 2023

Commit ID: 4b3afbcc27bcd94ccec6ab117700b18c2255e4db

Build ID: 15

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 5, 2023

Commit ID: 09e2017d641152c66339870173cac42e104aa21f

Build ID: 16

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 5, 2023

Commit ID: 09c9fa5ac73d426bb1affede293b6ee408119820

Build ID: 17

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@xiangyuzhi xiangyuzhi merged commit dadce86 into dmlc:master Sep 5, 2023
2 checks passed
@xiangyuzhi xiangyuzhi deleted the slicing-c branch September 13, 2023 08:03
peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023
@xiangyuzhi @frozenbugs
[Sparse] Add sparse matrix slicing operator implementation (dmlc#6208)
beed9c4 
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
@xiangyuzhi @frozenbugs @DominikaJedynak
[Sparse] Add sparse matrix slicing operator implementation (dmlc#6208)
6d58986 
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czkkkkkk czkkkkkk czkkkkkk approved these changes

@frozenbugs frozenbugs frozenbugs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xiangyuzhi @dgl-bot @frozenbugs @czkkkkkk