Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Do not fuse neighbor sampler for 1 thread #6421

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

anko-intel
Copy link
Collaborator

@anko-intel anko-intel commented Oct 10, 2023

Description

It fixes the issue #6315 (at least for CPU-only configuration)

The fused version of NeighborSampler (sample_neighbors_fused) is prepared as multithreaded, so we can not use it when the number of available threads is lower than 2.
This way we can achieve the same performance as previously with not fused version (which is also multithreaded but with less overhead).

Performance results of the script from the issue #6315 (modified to be allowed to run on CPU-only configuration) on AWS EC2 instance r6i.32xlarge (2 socket Intel(R) Xeon(R) Platinum 8375C) are as follow :

image

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 10, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 10, 2023

Commit ID: 05613e1

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs frozenbugs merged commit c94d2a5 into dmlc:master Oct 12, 2023
2 checks passed
peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants