Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heterograph.py #6506

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Update heterograph.py #6506

merged 8 commits into from
Nov 16, 2023

Conversation

willarliss
Copy link
Contributor

Protect temporary changes from persisting if an error occurs during the yield block.

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

Protect temporary changes from persisting if an error occurs during the yield block.
@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 27, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 27, 2023

Commit ID: 26564f4

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@willarliss
Copy link
Contributor Author

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 29, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 29, 2023

Commit ID: 2363647

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

@dgl-bot

@frozenbugs frozenbugs self-requested a review October 30, 2023 16:06
@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 30, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 30, 2023

Commit ID: 7c9a773

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 30, 2023

Commit ID: bdb0ea0624a2adc3d009df3d34a02425875c0083

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs frozenbugs requested review from Rhett-Ying and removed request for BarclayII October 31, 2023 02:39
@frozenbugs
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 31, 2023

Commit ID: 7c9a773

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Test case for changes to heterograph.py[6064:6068]
@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 15, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 15, 2023

Commit ID: f63138052d2e8042b9ab60273da7baad25f6ff14

Build ID: 6

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 15, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 15, 2023

Commit ID: 453b896

Build ID: 7

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 16, 2023

Commit ID: 24f36946228b230d0facc1b3e3a8842f9b26d437

Build ID: 8

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

tests/python/common/function/test_basics.py Outdated Show resolved Hide resolved
tests/python/common/function/test_basics.py Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 16, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 16, 2023

Commit ID: e762360e86a0498e19d4fca883d21bdeae9f63d9

Build ID: 9

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 16, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 16, 2023

Commit ID: e91d4a0e4a6c40a6995920728aae9c345b002de0

Build ID: 10

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@frozenbugs frozenbugs merged commit 12f02c3 into dmlc:master Nov 16, 2023
1 of 2 checks passed
peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants