Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset] Add CIFAR10 MNIST dataset in benchmark-gnn #6543

Merged
merged 4 commits into from
Nov 14, 2023
Merged

[Dataset] Add CIFAR10 MNIST dataset in benchmark-gnn #6543

merged 4 commits into from
Nov 14, 2023

Conversation

paoxiaode
Copy link
Collaborator

Description

The MNIST and CIFAR10 Superpixels dataset based on benchmark-gnn https://github.com/graphdeeplearning/benchmarking-gnns

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 8, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 8, 2023

Commit ID: dcc3422

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

rudongyu commented Nov 9, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 9, 2023

Commit ID: 78930ce127d6dd926f5d20dd082c4c505c629405

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

frozenbugs
frozenbugs reviewed Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@frozenbugs frozenbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @rudongyu to double check.

rudongyu
rudongyu reviewed Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@rudongyu rudongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done the first pass.

python/dgl/data/__init__.py Outdated Show resolved Hide resolved
python/dgl/data/superpixel.py Outdated Show resolved Hide resolved
python/dgl/data/superpixel.py Outdated Show resolved Hide resolved
python/dgl/data/superpixel.py Outdated Show resolved Hide resolved
python/dgl/data/superpixel.py Outdated Show resolved Hide resolved
python/dgl/data/superpixel.py Outdated Show resolved Hide resolved
python/dgl/data/superpixel.py Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 9, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 9, 2023

Commit ID: bb882dff93f19d932c0a6c0c55b272cfcfcf4241

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@paoxiaode
Copy link
Collaborator Author

Split SuperPixelDataset into MNISTSuperPixelDataset and CIFAR10SuperPixelDataset, please help me to check it again @rudongyu @frozenbugs

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 12, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 12, 2023

Commit ID: 7a236f199831a2b537ecac6a0ef714f4170ded23

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 13, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 13, 2023

Commit ID: df0b26e

Build ID: 5

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 13, 2023

Commit ID: df0b26e

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@rudongyu rudongyu merged commit 3274951 into dmlc:master Nov 14, 2023
2 checks passed
peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023
@paoxiaode @frozenbugs
[Dataset] Add CIFAR10 MNIST dataset in benchmark-gnn (dmlc#6543)
7b45c66 
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
@paoxiaode @frozenbugs @DominikaJedynak
[Dataset] Add CIFAR10 MNIST dataset in benchmark-gnn (dmlc#6543)
a285c7c 
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozenbugs frozenbugs frozenbugs approved these changes

@rudongyu rudongyu rudongyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paoxiaode @dgl-bot @rudongyu @frozenbugs