Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] update RGCN README #6996

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

Rhett-Ying
Copy link
Collaborator

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 23, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 23, 2024

Commit ID: 59581690a51e61a676e8ed70fef56aeae1739902

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator

mfbalin commented Jan 23, 2024

If we enable GPU sampling for this example as in #6958, the GPU runtimes should go down a lot more. Let's consider doing that or at least adding the option before the release?

@Rhett-Ying
Copy link
Collaborator Author

@mfbalin if new mode is added, you'd better update the README accordingly.

@mfbalin
Copy link
Collaborator

mfbalin commented Jan 23, 2024

@mfbalin if new mode is added, you'd better update the README accordingly.

I don't currently have the computational resources to run the mag240M example and update the numbers there. Could I ask you or anyone on the team to do that? That would be a big help.

@frozenbugs frozenbugs merged commit 2fedcdc into dmlc:master Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants