Rename DLContext to DLDevice #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Feb 19, 2021
tqchen
approved these changes
Feb 19, 2021
junrushao
approved these changes
Feb 19, 2021
|
Thanks @icemelon9 ! This PR is being merged |
|
Thanks! |
leofang
reviewed
Feb 20, 2021
| /*! \brief The device context of the tensor */ | ||
| DLContext ctx; | ||
| /*! \brief The device of the tensor */ | ||
| DLDevice device; |
There was a problem hiding this comment.
@tqchen @icemelon9 Unfortunately this breaks existing C code. Could you please revert the field name to ctx?
There was a problem hiding this comment.
@leofang this is intentional to keep the code consistent. The existing codebase can either stay at previous version, or upgrade the code to move to the new version. Exchange won't be affected by the version being used
There was a problem hiding this comment.
Ah OK, thanks. I failed to see this implication earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for the RFC #61 .
As discussed in the RFC, we will rename
DLContexttoDLDeviceand provideDLContextas an alias via typedef.cc: @tqchen @junrushao1994 @leofang @szha @kkraus14