Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

GBW vocab needs update #291

Closed
leezu opened this issue Aug 17, 2018 · 2 comments
Closed

GBW vocab needs update #291

leezu opened this issue Aug 17, 2018 · 2 comments

Comments

@leezu
Copy link
Contributor

leezu commented Aug 17, 2018 •
edited

#282 unified the BPTT interface. GBW before used both <eos> and <bos>. But #282 didn't update the default vocabulary file downloaded from S3. The vocabulary needs to be updated to remove <bos> as otherwise the sampling weights won't be correct, which seems to result in 0.5 higher train PPL.
@szha szha mentioned this issue Aug 17, 2018
Closed
20 tasks
@szha
Copy link
Member

szha commented Aug 17, 2018

WIP

@leezu leezu mentioned this issue Aug 17, 2018
Closed
4 tasks
@szha szha closed this as completed Aug 18, 2018
@szha
Copy link
Member

szha commented Aug 18, 2018

addressed in #294

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leezu @szha