Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[Block] Use fused gelu operator #1082

Merged
merged 3 commits into from Jan 4, 2020
Merged

[Block] Use fused gelu operator #1082

merged 3 commits into from Jan 4, 2020

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Dec 26, 2019

Description

Use fused gelu operator.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv TaoLv requested a review from a team as a code owner December 26, 2019 09:55
@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #1082 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1082   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          67       67           
  Lines        6266     6266           
=======================================
  Hits         5534     5534           
  Misses        732      732
Impacted Files Coverage Δ
src/gluonnlp/model/block.py 53.19% <100%> (ø) ⬆️

@mli
Copy link
Member

mli commented Dec 26, 2019

Job PR-1082/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1082/1/index.html

@TaoLv
Copy link
Member Author

TaoLv commented Dec 26, 2019

@eric-haibin-lin I assume that we need work on the master branch of gluonnlp. Please review.

Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having nested blocks makes the code hard to read. Shall we directly use F.LeakyRelu?

@mli
Copy link
Member

mli commented Dec 27, 2019

Job PR-1082/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1082/2/index.html

@mli
Copy link
Member

mli commented Jan 3, 2020

Job PR-1082/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1082/3/index.html

@eric-haibin-lin eric-haibin-lin merged commit 8272cef into dmlc:master Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants