[reorg] Move NER script out of bert folder #1090
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1090 +/- ##
==========================================
+ Coverage 78.51% 88.37% +9.85%
==========================================
Files 67 66 -1
Lines 6266 6290 +24
==========================================
+ Hits 4920 5559 +639
+ Misses 1346 731 -615
|
Job PR-1090/3 is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should a test running the finetune_ner / predict_ner scripts be added?
The problem is that we cannot distribute the dataset, so no test was added when it was first merged. But i did test manually with the CoNLL dataset for 1 epoch and it can run successfully. |
How about using a small Toy dataset of equivalent format? |
My concern is that it's easy to break the script if it's not run at all. |
Job PR-1090/4 is complete. |
Job PR-1090/5 is complete. |
Job PR-1090/6 is complete. |
Job PR-1090/7 is complete. |
Job PR-1090/8 is complete. |
Job PR-1090/9 is complete. |
Job PR-1090/10 is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you may still want to add a link in docs/model_zoo.rst
so that Sequence Labeling task is also highlighted on the front page (and not only as a small item in the left menu)
Job PR-1090/11 is complete. |
@leezu added to model_zoo.rst |
Description
#1081
Add a "sequence labeling" section in model zoo, with a BERT NER example.
Checklist
Essentials
Changes
Comments