Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[0.9.x] Add int8 command #1174

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Conversation

xinyu-intel
Copy link
Member

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@xinyu-intel xinyu-intel requested a review from a team as a code owner February 24, 2020 08:29
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #1174 into v0.9.x will increase coverage by 19.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.9.x   #1174       +/-   ##
==========================================
+ Coverage   68.88%   88.5%   +19.62%     
==========================================
  Files          72      72               
  Lines        6970    6970               
==========================================
+ Hits         4801    6169     +1368     
+ Misses       2169     801     -1368
Impacted Files Coverage Δ
src/gluonnlp/data/word_embedding_evaluation.py 89.31% <0%> (-6.88%) ⬇️
src/gluonnlp/data/glue.py 96.81% <0%> (-1.82%) ⬇️
src/gluonnlp/model/sequence_sampler.py 36.33% <0%> (+3.11%) ⬆️
src/gluonnlp/model/bert.py 94.62% <0%> (+3.28%) ⬆️
src/gluonnlp/embedding/evaluation.py 95.79% <0%> (+4.2%) ⬆️
src/gluonnlp/utils/files.py 42.62% <0%> (+4.91%) ⬆️
src/gluonnlp/model/train/language_model.py 90.32% <0%> (+5.06%) ⬆️
src/gluonnlp/model/bilm_encoder.py 100% <0%> (+5.08%) ⬆️
src/gluonnlp/model/convolutional_encoder.py 97.67% <0%> (+6.97%) ⬆️
src/gluonnlp/model/parameter.py 100% <0%> (+8%) ⬆️
... and 35 more

@mli
Copy link
Member

mli commented Feb 25, 2020

Job PR-1174/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1174/2/index.html

@eric-haibin-lin eric-haibin-lin merged commit 27331cb into dmlc:v0.9.x Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants