Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[Numpy] Fix conversion toolkits #1274

Merged
merged 26 commits into from
Jul 23, 2020
Merged

[Numpy] Fix conversion toolkits #1274

merged 26 commits into from
Jul 23, 2020

Conversation

zheyuye
Copy link
Member

@zheyuye zheyuye commented Jul 22, 2020

Description

  • Refactor the conversion toolkits to fit the current mxnet and gluonnlp as discussed in Update for Block API #1261 (comment)
  • Re-upload the mlm model for bert and generator model for electra

Comments

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #1274 into numpy will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            numpy    #1274      +/-   ##
==========================================
- Coverage   82.49%   82.44%   -0.06%     
==========================================
  Files          38       38              
  Lines        5491     5491              
==========================================
- Hits         4530     4527       -3     
- Misses        961      964       +3     
Impacted Files Coverage Δ
src/gluonnlp/models/bert.py 84.92% <ø> (+0.50%) ⬆️
src/gluonnlp/models/electra.py 78.94% <ø> (ø)
src/gluonnlp/utils/misc.py 48.18% <0.00%> (-1.45%) ⬇️

@sxjscience sxjscience merged commit 57eb411 into dmlc:numpy Jul 23, 2020
@zheyuye zheyuye deleted the conversion branch July 24, 2020 05:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants