[DEV] automatically generate date suffix for dev versions

[szha]

Description

automatically generate date suffix for dev versions

Checklist

Essentials

• PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
• Changes are complete (i.e. I finished coding on this PR)
• All changes have test coverage
• Code is well-documented

Changes

• automatically generate date suffix for dev versions

cc @dmlc/gluon-nlp-team

[szha]

with this change, I think we won't really need a nightly build as people can install from github directly and still has a version-number/date to reference.

[sxjscience]

In AutoGluon, the logic is to always use the dev version if it’s not a release: https://github.com/awslabs/autogluon/blob/30169a32ece713b676a77c785a2b6e6f2644bb80/setup.py#L17. Should we adopt the same logic? Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Sheng Zha <notifications@github.com> Sent: Monday, August 24, 2020 9:51:11 PM To: dmlc/gluon-nlp <gluon-nlp@noreply.github.com> Cc: Xingjian SHI <xshiab@connect.ust.hk>; Team mention <team_mention@noreply.github.com> Subject: Re: [dmlc/gluon-nlp] [DEV] automatically generate date suffix for dev versions (#1314) with this change, I think we won't really need a nightly build as people can install from github directly and still has a version-number/date to reference. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub<#1314 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABHQH3VQ3EZE5JUMS2ZL7NLSCM7L7ANCNFSM4QKGYSDA>.

[szha]

I don't think relying on an environment variable is the way to go. For one, this creates a leaky abstraction outside of version control. We have a proper path for managing different versions due to our use of release branches and tags, so there really isn't a need for the autogluon approach for us.

[sxjscience]

LGTM

[codecov]

Codecov Report

Merging #1314 into master will increase coverage by 0.17%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
+ Coverage   84.27%   84.45%   +0.17%     
==========================================
  Files          42       42              
  Lines        6423     6426       +3     
==========================================
+ Hits         5413     5427      +14     
+ Misses       1010      999      -11     

Impacted Files	Coverage Δ
setup.py	0.00% <0.00%> (ø)
src/gluonnlp/__init__.py	100.00% <100.00%> (ø)
src/gluonnlp/data/loading.py	83.39% <0.00%> (+5.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b14d69...2371eb4. Read the comment docs.