Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Update LM and namespace #53

Merged
merged 10 commits into from Apr 22, 2018
Merged

Update LM and namespace #53

merged 10 commits into from Apr 22, 2018

Conversation

cgraywang
Copy link
Contributor

Description

1, update LM to make the StandardRNN forward and AWDRNN forward align.
2, enable StandardRNN use beta L2 regularization.
3, add small AWDRNN model pretrained setting and results.
4, update LM example and script's namespace according to the discussion.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@cgraywang cgraywang requested a review from szha April 21, 2018 19:45
@cgraywang
Copy link
Contributor Author

@szha please help to upload the pretrained model, it looks like I zip the model in a wrong format... Thanks.

The original model is here:
https://drive.corp.amazon.com/personal/chgwang/pretrained_models_and_vocab/awd_lstm_lm_600_wikitext-2-7894a046f.params

@cgraywang
Copy link
Contributor Author

@leezu @szha
Please also help to take a look at:
#60

@mli
Copy link
Member

mli commented Apr 22, 2018

Job PR-53/8 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-53/8/index.html

@szha szha merged commit b19f820 into dmlc:master Apr 22, 2018
cgraywang added a commit to cgraywang/gluon-nlp-1 that referenced this pull request May 2, 2018
* update LM

* update lm

* update vocab

* update rst

* update code style

* update test

* update with new data api

* fix pylint

* add pretrained ref

* update test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants