Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[DOC] Update documentation for SplitSampler #603

Merged
merged 2 commits into from Feb 20, 2019

Conversation

eric-haibin-lin
Copy link
Member

Description

As title

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #603 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files         126      126           
  Lines       10994    10994           
=======================================
  Hits         7820     7820           
  Misses       3174     3174
Flag Coverage Δ
#PR594 71.21% <0%> (ø) ⬆️
#PR600 71.21% <0%> (ø) ⬆️
#PR603 71.21% <0%> (ø) ⬆️
#master 71.21% <0%> (ø) ⬆️
#notserial 49.03% <0%> (ø) ⬆️
#py2 70.91% <0%> (ø) ⬆️
#py3 70.94% <0%> (ø) ⬆️
#serial 54.63% <0%> (ø) ⬆️

@mli
Copy link
Member

mli commented Feb 20, 2019

Job PR-603/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-603/2/index.html

@mli
Copy link
Member

mli commented Feb 20, 2019

Job PR-603/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-603/3/index.html

@eric-haibin-lin eric-haibin-lin merged commit 1821ff9 into dmlc:master Feb 20, 2019
@eric-haibin-lin eric-haibin-lin deleted the sampler-doc branch May 9, 2019 04:54
paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019
* Update sampler.py

* Update sampler.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants