Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update documentation for SplitSampler #603

Merged
merged 2 commits into from Feb 20, 2019

Conversation

Projects
None yet
4 participants
@eric-haibin-lin
Copy link
Member

commented Feb 19, 2019

Description

As title

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from szha as a code owner Feb 19, 2019

@szha

szha approved these changes Feb 19, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 19, 2019

Codecov Report

Merging #603 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files         126      126           
  Lines       10994    10994           
=======================================
  Hits         7820     7820           
  Misses       3174     3174
Flag Coverage Δ
#PR594 71.21% <0%> (ø) ⬆️
#PR600 71.21% <0%> (ø) ⬆️
#PR603 71.21% <0%> (ø) ⬆️
#master 71.21% <0%> (ø) ⬆️
#notserial 49.03% <0%> (ø) ⬆️
#py2 70.91% <0%> (ø) ⬆️
#py3 70.94% <0%> (ø) ⬆️
#serial 54.63% <0%> (ø) ⬆️

@eric-haibin-lin eric-haibin-lin requested a review from cgraywang Feb 20, 2019

@mli

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

@eric-haibin-lin eric-haibin-lin requested a review from zhreshold Feb 20, 2019

Show resolved Hide resolved src/gluonnlp/data/sampler.py Outdated
@mli

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

@eric-haibin-lin eric-haibin-lin merged commit 1821ff9 into dmlc:master Feb 20, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@eric-haibin-lin eric-haibin-lin deleted the eric-haibin-lin:sampler-doc branch May 9, 2019

paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019

[DOC] Update documentation for SplitSampler (dmlc#603)
* Update sampler.py

* Update sampler.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.