Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[CI] Fix links in contribute.rst #752

Merged
merged 3 commits into from Jun 7, 2019
Merged

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Jun 7, 2019

contribute.rst currently contains invalid links. As CI checks links, this broke
all CI runs on the master branch. This should have broken all CI runs, including
pull-requests, but somehow didn't. This is tracked in #751.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Fix links in contribute.rst

@leezu leezu requested a review from szha as a code owner June 7, 2019 07:17
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

❗ No coverage uploaded for pull request head (fixcontributerst@f652240). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #752 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #752   +/-   ##
=======================================
  Coverage   90.71%   90.71%           
=======================================
  Files          64       64           
  Lines        6064     6064           
=======================================
  Hits         5501     5501           
  Misses        563      563

@leezu leezu added the release focus Progress focus for release label Jun 7, 2019
@mli
Copy link
Member

mli commented Jun 7, 2019

Job PR-752/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-752/1/index.html

@mli
Copy link
Member

mli commented Jun 7, 2019

Job PR-752/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-752/4/index.html

@szha szha merged commit f9ada0f into dmlc:master Jun 7, 2019
@leezu leezu mentioned this pull request Jun 8, 2019
paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019
* Fix links in contribute.rst

* Enforce linkcheck

* Fix Gluon Crash Course link
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release focus Progress focus for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants