Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Preserve stderr and stdout streams in doc CI stage for Cloudwatch #882

Merged

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Aug 16, 2019

In case a job times out, stdout.log and stderr.log files won't be uploaded to
S3.

Fixes #881

In case a job times out, stdout.log and stderr.log files won't be uploaded to
S3.
@leezu leezu requested a review from szha as a code owner August 16, 2019 17:38
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

❗ No coverage uploaded for pull request head (cidocpreservestdoutstderrforcloudwatch@88e5d5e). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #882 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #882   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files          66       66           
  Lines        6367     6367           
=======================================
  Hits         5755     5755           
  Misses        612      612

@leezu
Copy link
Contributor Author

leezu commented Aug 16, 2019

I checked the Cloudwatch logs. stderr and stdout shows up there now. So this should be merged

@leezu leezu requested a review from sxjscience August 16, 2019 18:10
@mli
Copy link
Member

mli commented Aug 16, 2019

Job PR-882/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-882/1/index.html

Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@eric-haibin-lin eric-haibin-lin merged commit 6d8b1d0 into dmlc:master Aug 16, 2019
@leezu leezu deleted the cidocpreservestdoutstderrforcloudwatch branch August 17, 2019 07:13
eric-haibin-lin pushed a commit that referenced this pull request Aug 18, 2019
#882)

In case a job times out, stdout.log and stderr.log files won't be uploaded to
S3.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing error log from CI
4 participants