-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
b29ecb2
to
92c2300
Compare
@Javelinjs some test error with Scala |
@@ -106,7 +106,7 @@ struct ImageAugmentParam : public dmlc::Parameter<ImageAugmentParam> { | |||
class ImageAugmenter { | |||
public: | |||
// contructor | |||
ImageAugmenter(void) { | |||
ImageAugmenter(void):param_() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implicit constructor do not have to be called
a78399b
to
5c0a8b6
Compare
@@ -608,9 +608,9 @@ void SimpleOpRegEntryImpl::RegisterBinaryImperative() { | |||
CHECK_EQ(lhs.shape(), rhs.shape()) << "operands shape mismatch"; | |||
dshape = lhs.shape(); | |||
} | |||
CHECK_EQ(lhs.ctx(), lhs.ctx()) | |||
CHECK_EQ(lhs.ctx(), rhs.ctx()) | |||
<< "operands context mismatch " << lhs.shape() << " vs. " << rhs.shape(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change shape to context
The scalar error seems to due to problem of using binary op for tensors from different devices, which is forbided and detected by the changes @yajiedesign added. @Javelinjs can you look a bit into it? @yajiedesign it is also OK if you can simply remove that testcase for now |
Sorry for the late reply. @yajiedesign Could you help to patch the following diff?
|
@Javelinjs yes ok |
No description provided.