This repository has been archived by the owner on Feb 1, 2020. It is now read-only.
force infer storage on backward pass (#1) #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* force infer storage type for backward pass * change none value for storage type to 0(kUndefinedStorage) * Modify default value for storage type
|
@piiswrong merging this will help me run some CI tests on PR apache/mxnet#5800 |
|
test failed |
|
@piiswrong updated unit test |
eric-haibin-lin
added a commit
to eric-haibin-lin/nnvm
that referenced
this pull request
Jun 7, 2017
piiswrong
pushed a commit
that referenced
this pull request
Jun 7, 2017
* [WIP] Infer Storage Type pass for sparse tensors (#110) * Add inferchunk pass * Fix default type for infet chunk * Add test for default chunk type * disable mem sharing for sparse storage. global name replacement * check dispatch_storage_type attr before retrieve it * fix typo * Add doc * Add kDynamic Storage * force infer storage on backward pass (#1) (#113) * force infer storage on backward pass (#1) * force infer storage type for backward pass * change none value for storage type to 0(kUndefinedStorage) * Modify default value for storage type * update unit test for infer storage * fix windows compilation error (#115) * remove unused logging
abergeron
pushed a commit
to abergeron/nnvm
that referenced
this pull request
May 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows inferstoragetype in backward pass. For type and shape, we can skip backward inter pass because it's always identical, but it's not the case for storage type (e.g. For sparse embedding operator, we'll output RowSparse weight gradients).