Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename byte serializer #482

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Rename byte serializer #482

merged 1 commit into from
Apr 28, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Apr 28, 2023

Don't refer to strings; refer to byte sequences instead

Don't refer to strings; refer to byte sequences instead
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.71 ⚠️

Comparison is base (af7baea) 85.33% compared to head (cbb6b05) 84.63%.

❗ Current head cbb6b05 differs from pull request most recent head 2e23ac0. Consider uploading reports for the commit 2e23ac0 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             mainline     #482      +/-   ##
==============================================
- Coverage       85.33%   84.63%   -0.71%     
  Complexity         42       42              
==============================================
  Files             112      111       -1     
  Lines            9914     8849    -1065     
  Branches          617       40     -577     
==============================================
- Hits             8460     7489     -971     
+ Misses           1431     1337      -94     
  Partials           23       23              
Impacted Files Coverage Δ
python/treelite/frontend.py 77.89% <100.00%> (ø)
src/c_api/c_api.cc 83.33% <100.00%> (+1.68%) ⬆️

... and 67 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hcho3 hcho3 merged commit 9087997 into dmlc:mainline Apr 28, 2023
16 checks passed
@hcho3 hcho3 deleted the rename_byte_serializer branch April 28, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant