Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CMake build #484

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Improve CMake build #484

merged 4 commits into from
Apr 28, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Apr 28, 2023

  • Add option to hide C++ symbols
  • Add option to "use system libtreelite.so." That is, if libtreelite.so is available in sys.prefix (e.g. Conda env), do not build another copy of libtreelite.so for the Python package. Previously, Conda's Treelite package would end up installing two copies of libtreelite.so.
  • Add option to select dynamic or static MSVC runtime
  • Use CMake's built-in directive CMAKE_MSVC_RUNTIME_LIBRARY instead of manually manipulating compiler flags. This helps us avoid cryptic CMake errors when using Treelite as a CMake sub-directory.
  • Prefix a few options with Treelite_ to make it easy for other downstream projects to use these options.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.70 ⚠️

Comparison is base (9087997) 85.34% compared to head (7382702) 84.65%.

❗ Current head 7382702 differs from pull request most recent head d76918f. Consider uploading reports for the commit d76918f to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             mainline     #484      +/-   ##
==============================================
- Coverage       85.34%   84.65%   -0.70%     
  Complexity         42       42              
==============================================
  Files             112      111       -1     
  Lines            9914     8849    -1065     
  Branches          617       40     -577     
==============================================
- Hits             8461     7491     -970     
+ Misses           1430     1335      -95     
  Partials           23       23              

see 68 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hcho3 hcho3 merged commit 6f78ae2 into dmlc:mainline Apr 28, 2023
15 of 16 checks passed
@hcho3 hcho3 deleted the msvc_runtime_lib branch April 28, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant