Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated pkg_resources #486

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented May 1, 2023

pkg_resources\__init__.py:121: DeprecationWarning: pkg_resources is deprecated as an API
    warnings.warn("pkg_resources is deprecated as an API", DeprecationWarning)

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.64 ⚠️

Comparison is base (46b194f) 85.31% compared to head (5c577a5) 84.68%.

❗ Current head 5c577a5 differs from pull request most recent head cc6a100. Consider uploading reports for the commit cc6a100 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             mainline     #486      +/-   ##
==============================================
- Coverage       85.31%   84.68%   -0.64%     
  Complexity         42       42              
==============================================
  Files             112      111       -1     
  Lines            9910     8849    -1061     
  Branches          617       40     -577     
==============================================
- Hits             8455     7494     -961     
+ Misses           1432     1332     -100     
  Partials           23       23              
Impacted Files Coverage Δ
python/treelite/contrib/msvc.py 0.00% <0.00%> (-68.12%) ⬇️
python/treelite/frontend.py 77.89% <100.00%> (ø)

... and 67 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hcho3 hcho3 merged commit af74664 into dmlc:mainline May 1, 2023
17 of 19 checks passed
@hcho3 hcho3 deleted the replace_pkg_resources branch May 1, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant