Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install gtest if building from source #491

Merged
merged 1 commit into from May 5, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented May 4, 2023

Also, enabling CPack.

Co-authored-by: Paul Taylor <paul.e.taylor@me.com>
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.65 ⚠️

Comparison is base (2566b4d) 85.32% compared to head (4eb6522) 84.68%.

❗ Current head 4eb6522 differs from pull request most recent head d160ee9. Consider uploading reports for the commit d160ee9 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             mainline     #491      +/-   ##
==============================================
- Coverage       85.32%   84.68%   -0.65%     
  Complexity         42       42              
==============================================
  Files             112      111       -1     
  Lines            9910     8849    -1061     
  Branches          617       40     -577     
==============================================
- Hits             8456     7494     -962     
+ Misses           1431     1332      -99     
  Partials           23       23              

see 68 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hcho3 hcho3 merged commit 4c48e16 into dmlc:mainline May 5, 2023
18 of 19 checks passed
@hcho3 hcho3 deleted the dont_install_gtest branch May 5, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants