Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model concatenation #538

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix model concatenation #538

merged 1 commit into from
Jan 11, 2024

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jan 11, 2024

Model concatenation is currently broken if average_tree_output is set to True.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78d12a2) 83.59% compared to head (68074f9) 83.58%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release_4.0     #538      +/-   ##
===============================================
- Coverage        83.59%   83.58%   -0.02%     
===============================================
  Files               70       70              
  Lines             6072     6073       +1     
  Branches           510      510              
===============================================
  Hits              5076     5076              
- Misses             996      997       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hcho3 hcho3 merged commit b7f1969 into dmlc:release_4.0 Jan 11, 2024
18 of 20 checks passed
@hcho3 hcho3 deleted the fix_model_concat branch January 11, 2024 21:28
hcho3 added a commit to hcho3/treelite that referenced this pull request Feb 1, 2024
hcho3 added a commit that referenced this pull request Feb 14, 2024
* Fix base_scores for sklearn GradientBoostingClassifier (#536)

* Update dev/prepare_pypi_release.py

* Fix base_scores for sklearn GradientBoostingClassifier

* Fix model concatenation (#538)

* Disable HistGradientBoostingClassifier tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant