Don't fetch GTest if it's found by CMake #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMake variable is `GTest_FOUND` not `GTEST_FOUND`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mainline #539 +/- ##
============================================
- Coverage 84.44% 84.21% -0.24%
============================================
Files 70 70
Lines 6063 6063
Branches 510 510
============================================
- Hits 5120 5106 -14
- Misses 943 957 +14 ☔ View full report in Codecov by Sentry. |
|
Thanks! I will make sure to backport this patch to the upcoming 4.0 release. |
hcho3
pushed a commit
to hcho3/treelite
that referenced
this pull request
Jan 11, 2024
The CMake variable is `GTest_FOUND` not `GTEST_FOUND`.
hcho3
added a commit
that referenced
this pull request
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake variable is
GTest_FOUNDnotGTEST_FOUND.