Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Set 1st dim of prediction output to be row ID #549

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Feb 15, 2024

When performing tree prediction in parallel, it is common to split the workload over the data row dimension. So it would be beneficial to put the row ID as the first (outer-most) dimension. In addition, both XGBoost and scikit-learn RandomForestRegressor puts the row ID in the first dimension when predicting with multi-target models.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5b1bbff) 84.33% compared to head (c509bfa) 84.29%.

Files Patch % Lines
src/gtil/predict.cc 95.83% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mainline     #549      +/-   ##
============================================
- Coverage     84.33%   84.29%   -0.04%     
============================================
  Files            71       71              
  Lines          6069     6068       -1     
  Branches        510      510              
============================================
- Hits           5118     5115       -3     
- Misses          951      953       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hcho3 hcho3 merged commit cb1aa86 into dmlc:mainline Feb 15, 2024
18 of 19 checks passed
@hcho3 hcho3 deleted the gtil_switch_dims branch February 15, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant