Vulkan TVM Android Support #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Vulkan Tvm Context added 2. Vulkan test case for rpc added
|
Welcome for review. |
|
@eqy can you also take a look? |
eqy
reviewed
Aug 8, 2018
| cost = time_f(a, b).mean | ||
| print('%g secs/op' % cost) | ||
| np.testing.assert_equal(b.asnumpy(), a.asnumpy() + 1) | ||
|
|
||
| print('Run CPU test ...') |
There was a problem hiding this comment.
Can we tweak the ordering of the tests so that the CPU test runs first? This provides some easy catching of common failure modes (e.g., the user did not link OpenCL so the CPU test runs but the GPU test fails).
| @@ -21,59 +21,86 @@ | |||
| arch = "arm64" | |||
| target = "llvm -target=%s-linux-android" % arch | |||
|
|
|||
| test_opencl = True | |||
| test_vulkan = False | |||
There was a problem hiding this comment.
Consider making these required command line options so we do not have broken defaults depending on the user's configuration (e.g., a CPU-only android device). We should also update the Android install docs to describe the test options (CPU, OpenCL, Vulkan).
There was a problem hiding this comment.
Okay, will work on comment
1. Review comment reworked.
|
Thanks @eqy reworked on review comment. |
1. Review comment reworked.
eqy
approved these changes
Aug 10, 2018
|
Thanks @dayanandasiet @eqy , this is merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.