[Keras] fix weight shape in dilated conv #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not ready for merge, one issue to fix. |
|
ready to merge now. |
|
please rebase against the master. @kazum @PariksheetPinjari909 please review |
kazum
requested changes
Sep 14, 2018
nnvm/python/nnvm/frontend/keras.py
Outdated
| alpha = keras_layer.alpha if hasattr(keras_layer, "alpha") else 1.6732 | ||
| gamma = keras_layer.gamma if hasattr(keras_layer, "gamma") else 1.0507 | ||
| alpha = keras_layer.alpha if hasattr(keras_layer, "alpha") else 1.67326324235437728481704299 | ||
| gamma = keras_layer.gamma if hasattr(keras_layer, "gamma") else 1.05070098735548049341933498 |
There was a problem hiding this comment.
Let's use the exact same values as the Keras project's ones.
https://github.com/keras-team/keras/blob/master/keras/activations.py#L80
alpha = 1.6732632423543772848170429916717
scale = 1.0507009873554804934193349852946
There was a problem hiding this comment.
Have updated. BTW, I previously used shorter alpha and scale in order not to exceed the 100 characters per line lint limit.
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The weight shape of dilated conv passed from frontend to nnvm compiler should be the original h and w, not including inserted zeros.