Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HybridScript] Capture constant external python variables #3157

Merged
merged 1 commit into from
May 10, 2019

Conversation

merrymercy
Copy link
Member

@merrymercy merrymercy commented May 9, 2019

Capture constant python variables (list/tuple/primitive) in HybridScript. We can use them to pass constant shape and attribute information.

cc @were @xqdan @kevinthesun

Copy link
Contributor

@xqdan xqdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen
Copy link
Member

tqchen commented May 9, 2019

@were can you help review this PR?

Copy link
Contributor

@kevinthesun kevinthesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait for comments from @were before merging.

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants