-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codegen/llvm] Emit DWARF debug information for LoweredFunc instances #3420
Conversation
aede7bb
to
b61f2d2
Compare
Thanks @ajtulloch please fix the CI error, and also tag a few more reviewers |
df73805
to
5b1a915
Compare
@ajtulloch I have retriggered the CI several times and the test consistently failed at the TOPI test, can you look into what happened? |
@tqchen sure will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo CI
@ajtulloch any leads? |
5b1a915
to
dd0555d
Compare
@tqchen I'll just tried emit it only for |
Thanks @ajtulloch @jroesch , this PR is merged |
Emit DWARF debug information. This allows us to set breakpoints on these generated functions, inspect arguments, show reasonable names in AOT mode in profiling tools, etc. There's a subsequent
perf
PR upcoming from Bram which augments this with support for Linuxperf
's jit interface, which makesperf
work in JIT scenarios.The implementation is fairly straightforward - for every LoweredFunc, we emit DWARF information for the function, it's signature, and it's arguments. You can see an example query in:
Some more screenshots from Bram: