Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] tvm.scan follow by tvm.compute segfault #3723

Merged
merged 4 commits into from
Aug 12, 2019

Conversation

yzhliu
Copy link
Member

@yzhliu yzhliu commented Aug 7, 2019

https://discuss.tvm.ai/t/possible-bug-with-tvm-scan/3642

Though I don't understand who fills d.data[k + 1]. @tqchen Please let me know if this quick fix makes sense.

cc @hzfan

@yzhliu yzhliu requested a review from tqchen August 7, 2019 11:05
@yzhliu yzhliu closed this Aug 8, 2019
@yzhliu yzhliu reopened this Aug 8, 2019
@yzhliu
Copy link
Member Author

yzhliu commented Aug 11, 2019

ping @tqchen

@hzfan hzfan mentioned this pull request Aug 12, 2019
1 task
@tqchen tqchen merged commit 8bef595 into apache:master Aug 12, 2019
@tqchen
Copy link
Member

tqchen commented Aug 12, 2019

thanks @yzhliu !

@tqchen
Copy link
Member

tqchen commented Aug 12, 2019

Thanks @hzfan for reporting the problem

wweic pushed a commit to neo-ai/tvm that referenced this pull request Aug 16, 2019
* [bugfix] tvm.scan follow by tvm.compute segfault

* more strict bound condition check

* access k + 1 -> k

* fix scan test
anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Aug 22, 2019
* [bugfix] tvm.scan follow by tvm.compute segfault

* more strict bound condition check

* access k + 1 -> k

* fix scan test
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
* [bugfix] tvm.scan follow by tvm.compute segfault

* more strict bound condition check

* access k + 1 -> k

* fix scan test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants