Skip to content

Commit

Permalink
Drop the xfail.
Browse files Browse the repository at this point in the history
  • Loading branch information
trivialfis committed Jul 7, 2021
1 parent 0699b15 commit 950cd65
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion src/data/sparse_page_dmatrix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ BatchSet<SortedCSCPage> SparsePageDMatrix::GetSortedColumnBatches() {
}

BatchSet<GHistIndexMatrix> SparsePageDMatrix::GetGradientIndex(const BatchParam& param) {
LOG(WARNING) << "External memory supporte for hist is working in progress.";
LOG(WARNING) << "External memory support for hist is working in progress.";
// External memory is not support
if (!ghist_index_source_ || (param != batch_param_ && param != BatchParam{})) {
ghist_index_source_.reset(new GHistIndexMatrix{this, param.max_bin});
Expand Down
1 change: 0 additions & 1 deletion tests/python-gpu/test_gpu_updaters.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def test_gpu_hist_device_dmatrix(self, param, num_rounds, dataset):
tm.dataset_strategy)
@settings(deadline=None)
def test_external_memory(self, param, num_rounds, dataset):
pytest.xfail(reason='TestGPUUpdaters::test_external_memory is flaky')
# We cannot handle empty dataset yet
assume(len(dataset.y) > 0)
param['tree_method'] = 'gpu_hist'
Expand Down

0 comments on commit 950cd65

Please sign in to comment.