more issues from checks

dmlc · Jan 7, 2024 · c2de386 · c2de386
1 parent 66591b1
commit c2de386
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/R-package/NAMESPACE b/R-package/NAMESPACE
@@ -95,6 +95,7 @@ importFrom(methods,new)
 importFrom(stats,coef)
 importFrom(stats,median)
 importFrom(stats,predict)
+importFrom(stats,sd)
 importFrom(utils,head)
 importFrom(utils,object.size)
 importFrom(utils,str)

diff --git a/R-package/R/callbacks.R b/R-package/R/callbacks.R
@@ -489,7 +489,7 @@ xgb.cb.evaluation.log <- function() {
         if (!is.data.table(prev_cb_res)) {
           prev_cb_res <- data.table::as.data.table(prev_cb_res)
         }
-        prev_take <- prev_cb_res[iter < min(evaluation_log$iter)] # nolint
+        prev_take <- prev_cb_res[prev_cb_res$iter < min(evaluation_log$iter)]
         if (nrow(prev_take)) {
           evaluation_log <- rbind(prev_cb_res, evaluation_log)
         }
@@ -1117,7 +1117,11 @@ xgb.gblinear.history <- function(model, class_index = NULL) {
     stop("model must be an object of either xgb.Booster or xgb.cv.synchronous class")
   is_cv <- inherits(model, "xgb.cv.synchronous")
 
-  coef_path <- getElement(attributes(model), "gblinear_history")
+  if (!is_cv) {
+    coef_path <- getElement(attributes(model), "gblinear_history")
+  } else {
+    coef_path <- getElement(model, "gblinear_history")
+  }
   if (is.null(coef_path)) {
     stop("model must be trained while using the xgb.cb.gblinear.history() callback")
   }

diff --git a/R-package/R/xgboost.R b/R-package/R/xgboost.R
@@ -99,6 +99,7 @@ NULL
 #' @importFrom stats coef
 #' @importFrom stats predict
 #' @importFrom stats median
+#' @importFrom stats sd
 #' @importFrom utils head
 #' @importFrom graphics barplot
 #' @importFrom graphics lines