Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] false-positive warning on CRAN #6151

Closed
jameslamb opened this issue Sep 23, 2020 · 1 comment
Closed

[R] false-positive warning on CRAN #6151

jameslamb opened this issue Sep 23, 2020 · 1 comment

Comments

@jameslamb
Copy link
Contributor

I was looking at https://cran.r-project.org/web/checks/check_results_xgboost.html tonight (looking for evidence of something while dealing with microsoft/LightGBM#3338 (comment)) and I saw that {xgboost} has a WARNING on Mac

image

I think this is just because R CMD check counts WARNINGs by literally grepping for the string "WARNING". This could be fixed by removing the word "WARNING" from this message:

echo 'WARNING: OpenMP is unavailable on this Mac OSX system. Training speed may be suboptimal.'

I'd be happy to open a PR that does that if you're interested!

@hcho3
Copy link
Collaborator

hcho3 commented Sep 23, 2020

@jameslamb Nice catch! Yes, a pull request is welcome. I will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants