Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] remove warning in configure.ac (fixes #6151) #6152

Merged
merged 2 commits into from
Sep 23, 2020
Merged

[R] remove warning in configure.ac (fixes #6151) #6152

merged 2 commits into from
Sep 23, 2020

Conversation

jameslamb
Copy link
Contributor

This PR proposes a fix for #6151 . I think it will resolve the WARNING on https://cran.r-project.org/web/checks/check_results_xgboost.html

image

Version: 1.2.0.1
Check: whether package can be installed
Result: WARN
    Found the following significant warnings:
     WARNING: OpenMP is unavailable on this Mac OSX system. Training speed may be suboptimal.
Flavor: r-release-macos-x86_64

@jameslamb
Copy link
Contributor Author

oh sorry forgot to update configure! will do that right now

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2020

Codecov Report

Merging #6152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6152   +/-   ##
=======================================
  Coverage   78.83%   78.83%           
=======================================
  Files          12       12           
  Lines        3090     3090           
=======================================
  Hits         2436     2436           
  Misses        654      654           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e033caa...bd35f6f. Read the comment docs.

@hcho3 hcho3 merged commit c686bc0 into dmlc:master Sep 23, 2020
@jameslamb jameslamb deleted the fix/r-warning branch June 1, 2021 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants