Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R Package] Use the C++ 11 compiler to test OpenMP flags #1881

Merged
merged 4 commits into from Dec 16, 2016

Conversation

yixuan
Copy link
Contributor

@yixuan yixuan commented Dec 16, 2016

According to the discussion in #1812 , the wrong OpenMP was passed to GCC on Solaris. The reason is that when running the configure script, the default compiler (Solaris Studio) was used, while GCC is the C++ 11 compiler to build the package. Therefore we need to set the CXX environment variable to the C++ 11 compiler in configure.

@codecov-io
Copy link

codecov-io commented Dec 16, 2016

Current coverage is 33.89% (diff: 100%)

Merging #1881 into master will increase coverage by 0.03%

@@             master      #1881   diff @@
==========================================
  Files            68         68          
  Lines          5281       5281          
  Methods         827        827          
  Messages          0          0          
  Branches        526        526          
==========================================
+ Hits           1788       1790     +2   
  Misses         3415       3415          
+ Partials         78         76     -2   

Powered by Codecov. Last update 5ebd8fb...a134498

@thirdwing
Copy link
Member

thirdwing commented Dec 16, 2016

When I submit the script early today, I also have these lines.

I removed them because on my solaris VM, it doesn't change the generated Makevars.

I think I know what's wrong now. The R from CSW (https://www.opencsw.org/packages/CSWr-base/) is configured in a different way from CRAN machine.

R version 3.3.0 (2016-05-03) -- "Supposedly Educational"
Copyright (C) 2016 The R Foundation for Statistical Computing
Platform: i386-pc-solaris2.10 (32-bit)

It seems I need to compile R from source on Solaris.

@hetong007 Please merge this and submit again.

@hetong007 hetong007 merged commit b14994a into dmlc:master Dec 16, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants