Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tweedie handling of base_score #3295

Merged
merged 2 commits into from Jun 28, 2018
Merged

Fix tweedie handling of base_score #3295

merged 2 commits into from Jun 28, 2018

Conversation

pdesahb
Copy link
Contributor

@pdesahb pdesahb commented May 4, 2018

Unlike reg:poisson, the ProbToMargin function for TweedieRegression was not defined so the base_score was not passed through a std::log.

@codecov-io
Copy link

codecov-io commented May 4, 2018

Codecov Report

Merging #3295 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3295      +/-   ##
============================================
- Coverage     45.58%   45.57%   -0.01%     
  Complexity      228      228              
============================================
  Files           166      166              
  Lines         12945    12947       +2     
  Branches        466      466              
============================================
  Hits           5901     5901              
- Misses         6852     6854       +2     
  Partials        192      192
Impacted Files Coverage Δ Complexity Δ
tests/cpp/objective/test_regression_obj.cc 95.61% <100%> (ø) 0 <0> (ø) ⬇️
src/objective/regression_obj.cc 84.73% <100%> (+0.11%) 0 <0> (ø) ⬇️
include/xgboost/objective.h 18.18% <0%> (-18.19%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a5c4d...5eb8020. Read the comment docs.

@hcho3 hcho3 merged commit 12e34f3 into dmlc:master Jun 28, 2018
CodingCat pushed a commit to CodingCat/xgboost that referenced this pull request Jul 26, 2018
* fix tweedie margin calculations

* add entry to contributors
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants