Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve update position function #3895

Merged
merged 1 commit into from Nov 14, 2018
Merged

Conversation

RAMitchell
Copy link
Member

I rewrote the radix sort function to optimise for the case of 1 bit keys (instances either go to the left node or right node). This is much faster, although impact on total program run-time is not very high. It also saves about 8 bytes per row of memory.

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #3895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3895   +/-   ##
=========================================
  Coverage     56.34%   56.34%           
  Complexity      203      203           
=========================================
  Files           185      185           
  Lines         14679    14679           
  Branches        495      495           
=========================================
  Hits           8271     8271           
  Misses         6170     6170           
  Partials        238      238

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 143475b...f9b4753. Read the comment docs.

@RAMitchell RAMitchell merged commit 7af0946 into dmlc:master Nov 14, 2018
@RAMitchell RAMitchell deleted the sort-position branch November 14, 2018 06:33
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants