Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sparse page segfault. #4040

Merged
merged 1 commit into from Jan 3, 2019
Merged

Fix sparse page segfault. #4040

merged 1 commit into from Jan 3, 2019

Conversation

trivialfis
Copy link
Member

  • Remove usage of raw pointers in SparsePageSource.

Address #4037.

@trivialfis
Fix sparse page segfault.
111757f 
* Remove usage of raw pointers in SparsePageSource.
@codecov-io
Copy link

codecov-io commented Jan 3, 2019 •
edited

Codecov Report

Merging #4040 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4040      +/-   ##
==========================================
+ Coverage   60.77%   60.79%   +0.01%     
==========================================
  Files         130      130              
  Lines       11699    11699              
==========================================
+ Hits         7110     7112       +2     
+ Misses       4589     4587       -2
Impacted Files Coverage Δ
src/data/sparse_page_source.cc 80.55% <100%> (ø) ⬆️
python-package/xgboost/libpath.py 70.83% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 431c850...111757f. Read the comment docs.

@trivialfis trivialfis merged commit 55bc149 into dmlc:master Jan 3, 2019
@trivialfis trivialfis mentioned this pull request Jan 3, 2019
Closed
@trivialfis trivialfis deleted the fix/sparse_page branch January 3, 2019 15:42
CodingCat pushed a commit to CodingCat/xgboost that referenced this pull request Jan 6, 2019
@trivialfis
Fix sparse page segfault. (dmlc#4040)
97285c1 
* Remove usage of raw pointers in SparsePageSource.
@hcho3 hcho3 mentioned this pull request Mar 4, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trivialfis @codecov-io