Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken R test: Install Homebrew GCC #4142

Merged
merged 9 commits into from Feb 15, 2019
Merged

Fix broken R test: Install Homebrew GCC #4142

merged 9 commits into from Feb 15, 2019

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Feb 14, 2019

Missing GCC Fortran causes installation failure of a dependency package (igraph).

@trivialfis @CodingCat @RAMitchell This should fix the R test.

@trivialfis
Copy link
Member

@hcho3 If this is a bug in some R dependencies, we might just report it to the upstream ... Watching your commit history I can almost feel your pain. :)

@hcho3
Copy link
Collaborator Author

hcho3 commented Feb 14, 2019

@trivialfis It appears to be configuration problem, where the Fortran compiler is not located properly. Looks like there is some difference between my Macbook Pro and Travis CI.

@trivialfis
Copy link
Member

@hcho3 Not having the correct toolchain after "configure" phase is a bug in build system. But it's autotools ... We can still raise an issue: https://github.com/igraph/rigraph

@hcho3
Copy link
Collaborator Author

hcho3 commented Feb 14, 2019

@trivialfis And now other dependencies are randomly failing to download :(

@hcho3
Copy link
Collaborator Author

hcho3 commented Feb 15, 2019

Let's see if we can come up with a minimal reproduction of the build bug in igraph...

@hcho3
Copy link
Collaborator Author

hcho3 commented Feb 15, 2019

Phew, the R build is finally fixed.

@trivialfis
Copy link
Member

Shall we merge it?

@hcho3 hcho3 merged commit 37ddfd7 into dmlc:master Feb 15, 2019
@hcho3 hcho3 deleted the fix_r_test branch February 15, 2019 17:46
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants