Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove RowSet which is no longer being used #4697

Merged
merged 1 commit into from
Jul 26, 2019
Merged

remove RowSet which is no longer being used #4697

merged 1 commit into from
Jul 26, 2019

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Jul 23, 2019

@rongou rongou closed this Jul 24, 2019
@rongou rongou reopened this Jul 24, 2019
@hcho3
Copy link
Collaborator

hcho3 commented Jul 24, 2019

@rongou It looks like the CI worker doesn't have proper access to the S3 object s3://xgboost-ci-jenkins-artifacts/spark-$SPARK_VERSION-bin-scala2.12-hadoop2.7.tgz. I'm puzzled why this is happening now, since #4574 passed tests successfully. Let me look.

@trivialfis trivialfis self-requested a review July 24, 2019 03:19
@hcho3 hcho3 mentioned this pull request Jul 25, 2019
Merged
@trivialfis
Copy link
Member

@rongou Would you like to rebase it onto master so the tests can pass?

@rongou
Copy link
Contributor Author

rongou commented Jul 25, 2019

@hcho3 looks like the python tests are still failing, but for a different reason now?

@hcho3
Copy link
Collaborator

hcho3 commented Jul 25, 2019 •
edited
Loading

@rongou See #4498. We'd like to move away from Travis CI asap.

@rongou
Copy link
Contributor Author

rongou commented Jul 25, 2019

@hcho3 ok finally passed.

@hcho3 hcho3 merged commit 9b9e298 into dmlc:master Jul 26, 2019
@rongou rongou deleted the remove-rowset branch August 2, 2019 17:02
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hcho3 hcho3 hcho3 approved these changes

@trivialfis trivialfis Awaiting requested review from trivialfis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rongou @hcho3 @trivialfis