[R] allow xgb.plot.importance() calls to fill a grid (fixes #4863) #6294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4863
I was looking for issues tagged r-package tonight and found #4863 . I think this PR fixes it.
Currently,
xgb.plot.importance()
overwrites all of the graphical parameters when it exits, which means that consecutive calls don't respectpar(mfcol)
, and don't fill a grid. This PR changes that, and just resets the specific valuemar
in the parameters.Here are the results on 4 consecutive calls of
xgb.plot.importance()
:before
after
Reproducible example
code (click me)
How this improves
{xgboost}
This allows the results of this function to be arranged in a grid, which could be useful for comparing feature importances across different models.
Thanks for your time and consideration