Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't validate feature when number of rows is 0. #6472

Merged
merged 1 commit into from Dec 7, 2020

Conversation

trivialfis
Copy link
Member

Close #6268 .

The script provided by @pseudotensor still fails due to auc doesn't handle empty dataset. But that will be tracked in #6272 .

@codecov-io
Copy link

codecov-io commented Dec 5, 2020

Codecov Report

Merging #6472 (1b9fd37) into master (703c2d0) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6472      +/-   ##
==========================================
+ Coverage   80.14%   80.29%   +0.15%     
==========================================
  Files          13       13              
  Lines        3515     3517       +2     
==========================================
+ Hits         2817     2824       +7     
+ Misses        698      693       -5     
Impacted Files Coverage Δ
python-package/xgboost/core.py 80.62% <100.00%> (+0.04%) ⬆️
python-package/xgboost/dask.py 82.13% <100.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55bdf08...1b9fd37. Read the comment docs.

@trivialfis trivialfis merged commit 47b8618 into dmlc:master Dec 7, 2020
@trivialfis trivialfis deleted the empty-dmatrix branch December 7, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dask_cudf: scikit-learn API leads to impossible train-time: ValueError("feature_names mismatch
3 participants