Pass correct split_type to GPU predictor #6491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6491 +/- ##
==========================================
- Coverage 80.35% 80.27% -0.09%
==========================================
Files 13 13
Lines 3533 3533
==========================================
- Hits 2839 2836 -3
- Misses 694 697 +3
Continue to review full report at Codecov.
|
RAMitchell
approved these changes
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPU predictor was producing incorrect prediction for models with categorical splits, because the whole
d_tree_split_typesspan was being passed to theGetLeafWeightkernel, when the kernel had expected a subspan corresponding to a single tree.This PR also adds a test example that fails with the current code and passes with the proposed patch.