[dask] Add DaskXGBRanker #6576
Merged
[dask] Add DaskXGBRanker #6576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question to myself: Right now the qid is required to be sorted for input. Maybe we need to perform the sorting ourselves? |
trivialfis
force-pushed
the
dask-ranker
branch
from
52348d0
to
ed76b8f
Compare
Codecov Report
@@ Coverage Diff @@
## master #6576 +/- ##
==========================================
+ Coverage 80.23% 80.49% +0.25%
==========================================
Files 13 13
Lines 3613 3665 +52
==========================================
+ Hits 2899 2950 +51
- Misses 714 715 +1
Continue to review full report at Codecov.
|
RAMitchell
approved these changes
Jan 8, 2021
|
I need to disable the support for group weight for now. The use of qid is to avoid having too many data manipulation code in Python. But per-group weight is kind of unavoidable. |
trivialfis
force-pushed
the
dask-ranker
branch
2 times, most recently
from
54d0795
to
0474666
Compare
hcho3
reviewed
Jan 8, 2021
hcho3
approved these changes
Jan 8, 2021
* Support `qid` in libxgboost. * Refactor `predict` and `n_features_in_`, `best_[score/iteration/ntree_limit]` to avoid duplicated code. * Define `DaskXGBRanker`. The dask ranker doesn't support group structure, instead it uses query id and convert to group ptr internally.
trivialfis
force-pushed
the
dask-ranker
branch
from
f406a48
to
fb50247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for distributed LTR using dask.
qidin libxgboost.predictandn_features_in_,best_[score/iteration/ntree_limit]to avoid duplicated code.DaskXGBRanker.The dask ranker doesn't support group structure, instead it uses query id and convert to group ptr internally.